-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed examples building #154
Conversation
merged argo.toml from examples/Cargo.toml
... I did not want to fix the documentation in the examples on how to run them in this until you were okay with this. |
I don't understand this... where is the alias? |
It's in top-level Cargo.toml in |
If you are okay with these changes then I'll go clean up the examples documentation on how to run them. Cheers |
I tracked down why you moved them in to their own crate in the first place. Which was to make the CI build run faster (you mentioned this on May 1) so I guess this entire thing is moot? :P |
It could be that gha caching has since been added, which itself would solve the build CI problem. |
I know that the checks above ran pretty fast for this PR ... if you like this change then I'll update the documentation. |
am happy with the change, but @stjepang is the one to decide |
I turned the examples directory into regular examples because there isn't much point in reducing smol's compilation time anymore. Smol is now just a small wrapper around the multitask crate. See #188 Thank you for this PR, though! |
merged Cargo.toml from examples/Cargo.toml.
This makes it possible to add examples into examples/ directory without having to explicitly add them into the [[examples]] array in Cargo.toml
If you wish to do a quick and dirty testing using the examples directory simply create it as examples/foo.rs or examples/foo/main.rs or examples/foo/lib.rs ;
Note the trick of adding smol = "." alias in dev-dependencies :P which not needing
extern crate smol;
in each example