Re-architect everything to be more secure (among other things) #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
smolck
changed the title
- Use the first argument of ipcMain.on/ipcRenderer.on as the event name, as it should've, instead of always using the same one. - Use the ipcMain.handle/ipcRenderer.invoke API - Add src/common/types, solely exposing `WindowMetadata` for now - Add src/common/ipc to make working with the stringly-typed EventEmitter interface of ipcMain/ipcRenderer less error-prone. - Perhaps some other small changes I'm not listing.
Now, to run a dev build, do `npm run dev`, and to run a prod build, do `npm run prod`.
…mote-slash-electronv12-migrate
|
Everything seems to be working well now, I may take some time to go through any |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This . . . is probably gonna take a while. May not even end up merging . . . but let's hope so, because that would make this a huge waste of time 😅
May update this description later to go into more detail about what I'm doing, why I'm doing it, etc. when I'm in more of a mood to describe things, but TL;DR is the architecture of veonim (and therefore uivonim) is a bit of a mess, and doesn't really follow modern best-practice at all. This PR should, at least somewhat, fix that, if all goes well.
Going ahead and getting this PR up but still lots more to be done before it's even close to mergeable, ATM this doesn't even build.
Some refs: