tcp: don't send data outside the remote window #387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we receive a packet with
ack_seq=1000, win_len=10
, this means the remote end is granting us permission to send bytes up toseq=1010
but no more.The current implementation limits segment length to
win
, but does not limit the byte count. In the example above, it'll send many small packets:1000-1010
,1010-1020
... until the entire tx_buffer is sent.This fixes the window handling so that only
1000-1010
is sent, and the rest isn't sent until the remote end sends a window update opening more space.test_established_send_buf_gt_win