Various cleanup suggested by cargo clippy #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were flagged by `cargo clippy`:
warning: this call to `as_ref` does nothing
warning: this call to `as_mut` does nothing
These were flagged by `cargo clippy`:
warning: using `println!("")`
warning: using `write!()` with a format string that ends in a single
newline
These were flagged by `cargo clippy`:
warning: unneeded `return` statement
These were flagged by `cargo clippy`:
warning: you don't need to add `&` to all patterns
whitequark
approved these changes
Dec 26, 2020
|
Thanks for this. Please do send the others! If we get all the lints cleaned up we could set clippy to hard-fail CI so they aren't reintroduced. Some should be disabled instead. For example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that PRs tend to get cluttered with a lot of warnings from
cargo clippy, so I went through and started addressing some of the suggestions where I thought they make sense. Here's a collection of changes that I thought were non-controversial, but I have a bunch more locally, if folks think these sorts of changes are helpful.