iface: check for ipv4 subnet broadcast addrs everywhere #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirbaio
force-pushed
the
subnet-broadcast-fix
branch
from
18afae0 to
93dc892
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#377 introduced subnet broadcast addr handling, but only in some places, causing #461.
This introduces
is_broadcast_v4andis_unicast_v4functions which are equivalent to thewireones except they check for subnet broadcast addrs. All uses for IPv4 addresses is replaced with these.IPv6 is left untouched as there's no such thing as a "ipv6 subnet broadcast addr"