Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export PollResult #993

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Export PollResult #993

merged 1 commit into from
Sep 19, 2024

Conversation

lrh2000
Copy link
Contributor

@lrh2000 lrh2000 commented Sep 19, 2024

#991 adds PollResult and PollIngressSingleResult. However, these two types are not accessible because they are in a private mod interface:

mod interface;

This needs to be fixed, otherwise no one can check the result returned by poll or poll_ingress_single:

pub fn poll(
&mut self,
timestamp: Instant,
device: &mut (impl Device + ?Sized),
sockets: &mut SocketSet<'_>,
) -> PollResult {

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.73%. Comparing base (9cc0657) to head (336e7e5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #993   +/-   ##
=======================================
  Coverage   80.73%   80.73%           
=======================================
  Files          81       81           
  Lines       28335    28335           
=======================================
  Hits        22877    22877           
  Misses       5458     5458           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, nice catch. thanks!

@Dirbaio Dirbaio added this pull request to the merge queue Sep 19, 2024
Merged via the queue into smoltcp-rs:main with commit d667a2a Sep 19, 2024
14 checks passed
@lrh2000 lrh2000 deleted the poll-result branch September 19, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants