Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PHP 8.3 features 🚀 #1775

Open
4 tasks
hemberger opened this issue Feb 4, 2024 · 0 comments
Open
4 tasks

Implement PHP 8.3 features 🚀 #1775

hemberger opened this issue Feb 4, 2024 · 0 comments

Comments

@hemberger
Copy link
Member

  • Add types to all class constants.
  • #[\Override] attribute for all intentionally overridden methods by child classes.
  • Replace random_* with Randomizer::getBytesFromString()
    • For random_alphabetic_string, we can replace this with a random letter followed by (N-1) random letters/numbers and merge it into random_string. This will ensure that the string always has at least one letter in it and thus won't be implicitly converted to a number.
  • Check if new DOMDocument methods can be leveraged.
hemberger added a commit to hemberger/smr that referenced this issue Dec 25, 2024
No changes, but is something we want to make sure is done in the future.

Related to smrealms#1775.
hemberger added a commit to hemberger/smr that referenced this issue Dec 25, 2024
Explicitly declare types for all class constants.

Related to smrealms#1775.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant