-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core.app 3.0: tick method, advanced app linking features #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...for nodes without push. Do collect valid push specs for all apps in the graph for use in breathe order computation. Only insert apps that have push() methods in final breathe_push_order array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a couple of features to core.app that should bridge the gap towards upstreaming @alexandergall’s ipfix changes.
tick()
As per #946 I added a n optional
tick()
method for apps useful for periodic housekeeping tasks. By default tick methods are called every millisecond.link(dir, name)
andunlink(dir, name)
Optional
link()
methods are now called with two arguments:dir
: "input" or "output"name
: the name of the link that has changedI.e., if a new link is added to an app you can access it during
link()
atself[dir][name]
.I also added an optional
unlink()
methos (with the same arguments) that gets called instead oflink()
if a link is removed.push_link
This is a new way to provide push methods specific to a particular link. Can be used dynamically during
link
. Here an excerpt from the updated readme:— Field myapp.push_link
Optional. When specified must be a table of per-link
push()
methodsthat take an input link as an argument. For example an app could specify
a push_link method for its input link foo:
Push_link methods are copied to a fresh table when the app is started,
and it is valid to create push_link methods dynamically during
link()
,for example like so:
Push is not called when an app has push_link methods
for all of its input links. If, however, an app at least one input link
without an associated push_link method then push is called
in addition to the push_link methods.