core.packet: Extend max packets from 100K to 1M #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packets are allocated dynamically on demand and this is only an artifical limit of "more than anybody should ever need" for catching unbounded allocations (leaks). (The limit also serves to make the freelist simple i.e. a fixed-size array.) The previous value of 100,000 is too low to serve its purpose: it is reasonable to allocate more than 100,000 packet buffers when managing many network receive queues and wanting to avoid packet drops. See discussion at: snabbco#882 (comment)
eugeneia
added a commit
that referenced
this pull request
Apr 26, 2016
takikawa
pushed a commit
to takikawa/snabb
that referenced
this pull request
Aug 5, 2017
takikawa
pushed a commit
to takikawa/snabb
that referenced
this pull request
Aug 5, 2017
takikawa
pushed a commit
to takikawa/snabb
that referenced
this pull request
Sep 4, 2017
raj2569
pushed a commit
to raj2569/snabb
that referenced
this pull request
Oct 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packets are allocated dynamically on demand and this is only an artifical limit of "more than anybody should ever need" for catching unbounded allocations (leaks). (The limit also serves to make the freelist simple i.e. a fixed-size array.)
The previous value of 100,000 is too low to serve its purpose: it is reasonable to allocate more than 100,000 packet buffers when managing many network receive queues and wanting to avoid packet drops.
See discussion at: #882 (comment)