vhost_user: Fix & comment "feature cache" #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a long description of the "feature cache" and how it supports reconnecting to a running QEMU. Added a restriction so that the cache is only considered for the first feature negotiation performed by a vhost-user app instance. This is to avoid using the cached features when renegotiating with a guest e.g. when the guest has switched to a new driver. Not yet tested.
|
Neat! Will try. One question: the C.VIRTIO_NET_F_MQ feature is offered by net_device.lua, but it doesn't make it through to the guest. Could that be QEMU getting in the way? |
|
I have tested this one locally and it works for me. |
eugeneia
added a commit
that referenced
this pull request
Jun 9, 2016
dpino
added a commit
to dpino/snabb
that referenced
this pull request
Sep 12, 2017
Add -j option to "snabb lwaftr run" and "bench"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a long description of the "feature cache" and how it supports reconnecting to a running QEMU.
Added a restriction so that the cache is only considered for the first feature negotiation performed by a vhost-user app instance. This is to avoid using the cached features when renegotiating with a guest e.g. when the guest has switched to a new driver.
Not yet tested! Should fix #932. cc @wingo