virtio/net_device: Fix bug with mergeable rx buffers #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snabb could over-report the size of jumbo packets delivered to the VM under certain circumstances.
|
Interesting! Note that Igalia@df8e83c implies that this code is running in all cases, whether or not MRG_RXBUF is negotiated, if QEMU first negotiated to have MRG_RXBUF on. |
eugeneia
added a commit
that referenced
this pull request
Jun 9, 2016
lukego
added a commit
that referenced
this pull request
Jun 10, 2016
|
I fast-tracked this change onto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snabb could over-report the size of jumbo packets delivered to the VM under certain circumstances.
This was detected when using jumbo frames with VMs that were bootstrapped with nix. Could not be reproduced with Ubuntu guests.
I resisted the urge to refactor the virtio device code more because this will be faster and safer once we complete some related work with Hydra for testing many software combinations.