intel1g: canonicalize env var name, pass it through dock.sh #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,7 +35,7 @@ | |||
| -- Note: section and page numbers in the comments below refer to the i210 data sheet | |||
|
|
|||
| -- run selftest() on APU2's second/middle NIC: | |||
| -- sudo SNABB_SELFTEST_INTEL1G_0="0000:02:00.0" ./snabb snsh -t apps.intel.intel1g | |||
| -- sudo SNABB_PCI_INTEL1G0="0000:02:00.0" ./snabb snsh -t apps.intel.intel1g | |||
There was a problem hiding this comment.
I really don't approve of hardcoding PCI addresses, but I don't consider that a blocker for this patch, as it was also previously hardcoded.
kbara
pushed a commit
to kbara/snabb
that referenced
this pull request
Jul 1, 2016
dpino
added a commit
to dpino/snabb
that referenced
this pull request
Sep 15, 2017
Implement compress alarms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
dock.shpass through the required environment variable for the intel1g selftest, enabling SnabbBot to run it.