Several Snabb-bot improvements #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dpino
commented
Jul 14, 2016
dpino
commented
- Remove temporary dirs before creating them.
- Allow Snabb-bot to work with GitHub private repositories.
- Use OAuth CLIENT_ID and CLIENT_SECRET parameters to increase number of requests per hour.
Appending these parameters to a GitHub URL increase the number of requests per second [1] [1] https://developer.github.com/v3/#rate-limiting
| @@ -26,13 +26,18 @@ function init { | |||
| fi | |||
| export logdir="$SNABBBOTDIR/log" | |||
| export tmpdir="$SNABBBOTDIR/tmp" | |||
| rm -Rf "$SNABBBOTDIR" "$logdir" "$tmpdir" | |||
There was a problem hiding this comment.
$logdir is actually supposed to persist (it caches results, otherwise everything is recomputed all the time).
This reverts commit 1e59dc7.
eugeneia
added a commit
to eugeneia/snabb
that referenced
this pull request
Jul 21, 2016
…to snabb_ci # Conflicts: # src/scripts/snabb_bot.sh
takikawa
pushed a commit
to takikawa/snabb
that referenced
this pull request
Sep 25, 2017
Use false instead of "off" to disable intel_mp txq/rxq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.