Skip SnabbNFV test if cannot find QEMU image #986
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In master, the SnabbNFV selftest always tries to run a QEMU image regardless whether an image file exists or not. In case it doesn't exist, the process which tries to log into the VM keeps waiting until it times out with an exit error.
In an earlier version the test was skipped if SNABB_PCI0 was not defined. But now SNABB_PCI0 is always defined. In my opinion, the test should be skipped if there's not QEMU file image available.