Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip SnabbNFV test if cannot find QEMU image #986

Merged
merged 1 commit into from
Sep 2, 2016

Conversation

dpino
Copy link
Contributor

@dpino dpino commented Aug 3, 2016

In master, the SnabbNFV selftest always tries to run a QEMU image regardless whether an image file exists or not. In case it doesn't exist, the process which tries to log into the VM keeps waiting until it times out with an exit error.

src $ sudo ./program/snabbnfv/selftest.sh
Defaulting to SNABB_TELNET0=5000
Defaulting to SNABB_TELNET1=5001
Defaulting to SNABB_IPERF_BENCH_CONF=program/snabbnfv/test_fixtures/nfvconfig/test_functions/same_vlan.ports
USING program/snabbnfv/test_fixtures/nfvconfig/test_functions/other_vlan.ports
Defaulting to MAC=52:54:00:00:00:
Defaulting to IP=fe80::5054:ff:fe00:
Defaulting to GUEST_MEM=512
Defaulting to HUGETLBFS=/hugetlbfs
Defaulting to QUEUES=1
Defaulting to QEMU=/usr/bin/qemu-system-x86_64
cp: cannot stat ‘/home/dpino/.test_env/qemu.img’: No such file or directory
cp: cannot stat ‘/home/dpino/.test_env/qemu.img’: No such file or directory
Waiting for VM listening on telnet port 5000 to get ready...

In an earlier version the test was skipped if SNABB_PCI0 was not defined. But now SNABB_PCI0 is always defined. In my opinion, the test should be skipped if there's not QEMU file image available.

eugeneia added a commit that referenced this pull request Aug 3, 2016
@eugeneia eugeneia self-assigned this Aug 3, 2016
@eugeneia eugeneia added the merged label Aug 3, 2016
@eugeneia eugeneia merged commit 64491b9 into snabbco:master Sep 2, 2016
@dpino dpino deleted the skip-snabbnfv-test branch September 6, 2016 06:16
dpino added a commit to dpino/snabb that referenced this pull request Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants