MDL-79114 core: fix upgrade step remove basicoutcomes subplugin

snake · Nov 20, 2023 · 685dee4 · 685dee4
1 parent 381cf35
commit 685dee4
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/lib/db/upgrade.php b/lib/db/upgrade.php
@@ -3707,17 +3707,21 @@ function xmldb_main_upgrade($oldversion) {
             set_config('privatekey', null, 'mod_lti');
         }
 
+        // Main savepoint reached.
+        upgrade_main_savepoint(true, 2023102000);
+    }
+
+    if ($oldversion < 2023111600.00) {
         $servicetypes = ['basicoutcomes'];
         foreach ($servicetypes as $type) {
-            $versionFile = $CFG->dirroot . "mod/lti/service/{$type}/version.php";
-        
+            $versionFile = $CFG->dirroot . "mod/lti/service/$type/version.php";
+
             if (!file_exists($versionFile)) {
-                // Clean config.
-                unset_all_config_for_plugin("ltiservice_$type");
+                uninstall_plugin('ltiservice', 'basicoutcomes');
             }
         }
         // Main savepoint reached.
-        upgrade_main_savepoint(true, 2023102000);
+        upgrade_main_savepoint(true, 2023111600.00);
     }
 
     return true;