fix: handle cases when running inside a kubernetes cluster #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current setup for the plugin assumes that we have a kubeconfig file used to connect to the cluster. However, this is not the case if the code submitting the job is itself running in a pod in the cluster, as we will need to use the default service account provided by the cluster This modifies the init to catch any errors when loading a kubeconfig file and use the inlcuster configuration instead
mangosense
approved these changes
Apr 2, 2024
johanneskoester
approved these changes
Aug 14, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current setup for the plugin assumes that we have a kubeconfig file used to connect to the cluster. However, this is not the case if the code submitting the job is itself running in a pod in the cluster, as we will need to use the default service account provided by the cluster. This modifies the init to catch any errors when loading a kubeconfig file and use the incluster configuration instead
The issue in the python kubernetes client here describes the problem:
kubernetes-client/python#1005