Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yyuan/neg sample study #278

Closed
wants to merge 6 commits into from
Closed

Yyuan/neg sample study #278

wants to merge 6 commits into from

Conversation

yiweny
Copy link
Collaborator

@yiweny yiweny commented Nov 24, 2024

No description provided.

Copy link
Collaborator

@rishabh-ranjan rishabh-ranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you describe this PR please? Thanks

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this should be in examples?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am trying to support sampling pos/negs with different ratios. But I hit some technical difficulties.

Copy link
Collaborator

@rishabh-ranjan rishabh-ranjan Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For PRs that don't work yet, can you please make them "draft PRs" in the future? thanks

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh. my b

@rishabh-ranjan rishabh-ranjan marked this pull request as draft November 25, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants