[#2826]trim values before search #2844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megumiimai
changed the title
caseyjhol
requested changes
Nov 21, 2023
| @@ -2951,6 +2951,10 @@ | |||
|
|
|||
| this.$searchbox.on('input propertychange', function () { | |||
| var searchValue = that.$searchbox[0].value; | |||
| var isWhitespace = /^\s*$/.test(searchValue); | |||
| if (!isWhitespace) { | |||
| searchValue = searchValue.replace(/^\s+|\s+$/g, ''); | |||
There was a problem hiding this comment.
I think we're probably okay to just use searchValue = searchValue.trim(); instead.
There was a problem hiding this comment.
@caseyjhol
thank you very much.
Since some users sometimes enter full-width spaces, so I have added support for trimming all half-width spaces and full-width spaces.
There was a problem hiding this comment.
Ah gotcha. Maybe just mention this in a brief comment above this line.
There was a problem hiding this comment.
I have added a comment. thank you.
caseyjhol
requested changes
Nov 28, 2023
| @@ -2951,6 +2951,10 @@ | |||
|
|
|||
| this.$searchbox.on('input propertychange', function () { | |||
| var searchValue = that.$searchbox[0].value; | |||
| var isWhitespace = /^\s*$/.test(searchValue); | |||
| if (!isWhitespace) { | |||
| searchValue = searchValue.replace(/^\s+|\s+$/g, ''); | |||
There was a problem hiding this comment.
Ah gotcha. Maybe just mention this in a brief comment above this line.
caseyjhol
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved #2826
Make sure to target the
devbranch!