-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: changes for core24 snaps to build #43
Conversation
Will take a look tomorrow - this logic is getting more complicated than I'd like by now! |
Please take your time.
Disabling fall-back isn't necessary, I just did it as I found the scope. (The new backend is very fast and feels very nice to see 🥲 ) But restricting the architectures are very necessary as needed by the core22 snaps before. |
I'm a little confused because the architecture restriction should happen through the use of the As far as I know, the current code works for core24 - there is an example run here, with the corresponding snapcraft.yaml. Could you point me to where this fails for you? |
https://github.com/soumyaDghosh/webkitgtk-sdk/actions/runs/9530513048/job/26270468434 https://github.com/soumyaDghosh/webkitgtk-sdk/actions/runs/9530526618/job/26270504427 See, it's not working |
I don't think that's because of the platforms definition. @mr-cal - any ideas (I'm afk and only have my phone for a few days!) @soumyaDghosh can you reproduce locally? |
Yes, I first tested this locally and then went to try the ci. |
This might be an issue with your authentication token not having the full ACL required. The LaunchpadError looks like it is trying to issue an API call which is failing. The first thing is to confirm which ACL entries you need on your authentication token and regenerate it to ensure you have a valid token with the appropriate ACL to see if that fixes it. |
Nope tried with new secret. Still the same https://github.com/soumyaDghosh/webkitgtk-sdk/actions/runs/9533180559/job/26276132086 |
@jnsgruk Builds once again failed here https://github.com/soumyaDghosh/ffmpeg-sdk/actions/runs/9548427970/job/26315614173 |
I'll try remote building your snaps locally and see if I can reproduce. If I can't, updating the CI job to set |
@soumyaDghosh - can you try one of the debugging strategies I mentioned above? I've tried a few variations of remote-builds of |
I think this is ready to be merged - this is a small change that only realistically affects a small portion of our snaps, some of which are blocked by the change. I'll merge this, and we experience problems it can be reverted. |
This PR makes some necessary changes to make core24 snaps build with remote build.