Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: changes for core24 snaps to build #43

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Conversation

soumyaDghosh
Copy link
Member

This PR makes some necessary changes to make core24 snaps build with remote build.

  1. disables force-fallback
  2. restricts other architectures

@jnsgruk
Copy link
Member

jnsgruk commented Jun 14, 2024

Will take a look tomorrow - this logic is getting more complicated than I'd like by now!

@soumyaDghosh
Copy link
Member Author

Please take your time.

Will take a look tomorrow - this logic is getting more complicated than I'd like by now!

Disabling fall-back isn't necessary, I just did it as I found the scope. (The new backend is very fast and feels very nice to see 🥲 ) But restricting the architectures are very necessary as needed by the core22 snaps before.

@jnsgruk
Copy link
Member

jnsgruk commented Jun 15, 2024

I'm a little confused because the architecture restriction should happen through the use of the --platforms arg which is added on the next line. I think I'm going to hold on this, as we're still ironing out a couple of bugs in the new builder.

As far as I know, the current code works for core24 - there is an example run here, with the corresponding snapcraft.yaml.

Could you point me to where this fails for you?

@soumyaDghosh
Copy link
Member Author

I'm a little confused because the architecture restriction should happen through the use of the --platforms arg which is added on the next line. I think I'm going to hold on this, as we're still ironing out a couple of bugs in the new builder.

As far as I know, the current code works for core24 - there is an example run here, with the corresponding snapcraft.yaml.

Could you point me to where this fails for you?

https://github.com/soumyaDghosh/webkitgtk-sdk/actions/runs/9530513048/job/26270468434

https://github.com/soumyaDghosh/webkitgtk-sdk/actions/runs/9530526618/job/26270504427

See, it's not working

@jnsgruk
Copy link
Member

jnsgruk commented Jun 15, 2024

I don't think that's because of the platforms definition. @mr-cal - any ideas (I'm afk and only have my phone for a few days!)

@soumyaDghosh can you reproduce locally?

@soumyaDghosh
Copy link
Member Author

@soumyaDghosh can you reproduce locally?

Yes, I first tested this locally and then went to try the ci.

@lucyllewy
Copy link
Member

This might be an issue with your authentication token not having the full ACL required. The LaunchpadError looks like it is trying to issue an API call which is failing. The first thing is to confirm which ACL entries you need on your authentication token and regenerate it to ensure you have a valid token with the appropriate ACL to see if that fixes it.

@soumyaDghosh
Copy link
Member Author

@soumyaDghosh
Copy link
Member Author

@mr-cal
Copy link

mr-cal commented Jun 17, 2024

I'll try remote building your snaps locally and see if I can reproduce.

If I can't, updating the CI job to set CRAFT_DEBUG=1 and --verbosity=trace in CI or cat'ing the full snapcraft logs would be very useful.

@mr-cal
Copy link

mr-cal commented Jun 17, 2024

@soumyaDghosh - can you try one of the debugging strategies I mentioned above?

I've tried a few variations of remote-builds of webkitgtk-6-gnome-2404-sdk and I'm run into this known bug but I can't reproduce the errors you are seeing. They look more like launchpadlib api-related issues.

@jnsgruk
Copy link
Member

jnsgruk commented Jul 12, 2024

I think this is ready to be merged - this is a small change that only realistically affects a small portion of our snaps, some of which are blocked by the change. I'll merge this, and we experience problems it can be reverted.

@jnsgruk jnsgruk merged commit ad6972e into snapcrafters:main Jul 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants