Merge pull request #487 from rvanlaak/patch-2

Conditionally enable lazy loading for `phpredis`
snc · Jan 17, 2019 · f12228d · f12228d
2 parents 6633198 + 7987c8e
commit f12228d
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/DependencyInjection/SncRedisExtension.php b/DependencyInjection/SncRedisExtension.php
@@ -276,7 +276,17 @@ protected function loadPhpredisClient(array $client, ContainerBuilder $container
         $phpredisDef->addArgument($client['alias']);
         $phpredisDef->addTag('snc_redis.client', array('alias' => $client['alias']));
         $phpredisDef->setPublic(false);
-        $phpredisDef->setLazy(true);
+
+        // Older version of phpredis extension do not support lazy loading
+        $minimumVersionForLazyLoading = '4.1.1';
+        $supportsLazyServices = version_compare($phpRedisVersion, $minimumVersionForLazyLoading, '>=');
+        $phpredisDef->setLazy($supportsLazyServices);
+        if (!$supportsLazyServices) {
+            @trigger_error(
+                sprintf('Lazy loading Redis is not supported on PhpRedis %s. Please update to PhpRedis %s or higher.', $phpRedisVersion, $minimumVersionForLazyLoading), 
+                E_USER_WARNING
+            );    
+        }
 
         $container->setDefinition($phpredisId, $phpredisDef);
         $container->setAlias(sprintf('snc_redis.%s', $client['alias']), new Alias($phpredisId, true));