Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Compression #331

Closed
The-Don-Himself opened this issue Feb 28, 2017 · 5 comments
Closed

Feature Request: Compression #331

The-Don-Himself opened this issue Feb 28, 2017 · 5 comments

Comments

@The-Don-Himself
Copy link

I have been pondering the best place to request this, threads on redis discussions suggest within the app code to be the best place.

Compression of values can save at least 50% RAM in my Symfony app tests. Is this something SncRedisBundle can handle especially when Redis is used as a cache?

A see a few potential issues, though like if many App servers are connecting to a central Redis then they all must have the same compression library and version installed.

Thoughts?

@The-Don-Himself
Copy link
Author

Just came across this PR that allows SncRedisBundle to explicitly select a serializer. Choosing igbinary might result in significant data compression savings about ~50% according to many benchmarks like this drupal discussion.

#297

@dbergunder
Copy link

👍 This would be a great addition.

@pounard
Copy link

pounard commented Jan 23, 2018

Using gzip may hold up to 80% memory saving, I implemented it in the Drupal Redis module. Until now, it never affected performance, but on many system hold a huge memory save.

@The-Don-Himself
Copy link
Author

Seems to be solved by today's release v 2.1.1 by selecting Igbinary serializer, this PR by @yellow1912 adding this great option #411
Would have loved to see json_encode as a serializer option since it allows portability with other programming languages like GO while still improving memory savings.

@curry684
Copy link
Collaborator

You're welcome, wasn't aware of this issue or I'd have pinged you 😄

If you see viable improvements by all means send a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants