Allow setting serializer for Redis client #297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by commit 199 (#199), this commits add support for setting serializer option for Redis client. There are many cases where setting a specific Serializer (or none) can be very helpful. The default serializer is set to default, which allows the Adapter to automatically detect best Serializer to use.
piotrkochan
approved these changes
Feb 22, 2018
|
Could someone check this PR? |
|
I'm not sure I understand the trade-offs between this and #199.. what's the upside/downside? |
|
Closed in favor of #411 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by commit 199 (#199), this commits add support
for setting serializer option for Redis client. There are many cases where
setting a specific Serializer (or none) can be very helpful.
The default serializer is set to default, which allows the Adapter to
automatically detect best Serializer to use.