Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replication: sentinel (currently on master branch) launches AUTH to sentinel instances #339

Closed
varas opened this issue Apr 6, 2017 · 5 comments

Comments

@varas
Copy link

varas commented Apr 6, 2017

This is a bug in the master brach since this merge 104df22#diff-fd809ec659d77076dce28d9ea225b8f6L139

There is no way in config to distinguish between sentinel instances and redis ones.

When trying to connect to password protected redis instances I tried adding password via DSN, as it's the only way supported by the bundle.
https://github.com/snc/SncRedisBundle/blob/master/DependencyInjection/SncRedisExtension.php#L263-L264

So every time there is a password argument bundle converts password to an AUTH command, that is not supported by sentinel instances at the time: redis/redis#3279

Also: error is misleading as response command is not nicely handled by predis (see pic) and get masked as array access error.
screen shot 2017-04-06 at 13 13 26

@snc
Copy link
Owner

snc commented Apr 12, 2017

@othillo can you have a look at this please (see #307)? I have never used sentinal, so you may have an idea about this issue.

@evgeny-s
Copy link

evgeny-s commented Apr 18, 2017

@othillo, also a question here:
We moving to the sentinels architecture of our redis servers, and we use phpredis.
As we expected, it should be something like this:

  1. We configure sentinels like this: host and port (26379 as default)
  2. First client ask sentinel with request like ('GET-MASTER-ADDR-BY-NAME') and then connect to the server with master role. I didn't find any reference to this command, seems now it works differently. Fix me if I mistaken.

Seems this is not possible to use phpredis for cluster connection.
Is it planned in the near future to add this feature?

Thank you very much.

@curry684
Copy link
Collaborator

curry684 commented Apr 6, 2018

I don't have access to Sentinel, can anyone confirm this was fixed properly by #340?

@varas
Copy link
Author

varas commented Apr 9, 2018

I'm not longer working on this, but it seems to be solved at #340 (comment)

@varas varas closed this as completed Apr 9, 2018
@curry684
Copy link
Collaborator

curry684 commented Apr 9, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants