allow sentinel replication configuration #307
Conversation
othillo
changed the title
othillo
changed the title
|
I checked out this code and it works as i was hopping in my test environment. I did however add a extra parameter to make sure selecting a database is an option. |
| @@ -135,7 +135,8 @@ private function addClientsSection(ArrayNodeDefinition $rootNode) | |||
| ->end() | |||
| ->scalarNode('cluster')->defaultNull()->end() | |||
| ->scalarNode('prefix')->defaultNull()->end() | |||
| ->booleanNode('replication')->defaultFalse()->end() | |||
| ->enumNode('replication')->values(array(true, false, 'sentinel'))->defaultNull()->end() | |||
| ->scalarNode('service')->defaultNull()->end() | |||
There was a problem hiding this comment.
Adding this will enable people to select a database if they choose:
->arrayNode('parameters') ->children() ->scalarNode('database')->defaultNull()->end() ->end() ->end()
There was a problem hiding this comment.
@MyDigitalLife do you mind creating a pull request for this with a test case?
|
What does |
|
@snc |
|
Is there a time table when this feature will be merged? |
|
I'm also interested in this feature. |
|
Any update on why this isn't merged yet? |
|
@othillo Could you add some lines to the readme about this feature? |
Resources/doc/index.md
Outdated
| service: mymaster | ||
| ``` | ||
|
|
||
| The `service` is the name of the set or Redis instances. |
There was a problem hiding this comment.
Should be "of Redis instances" right? :-)
|
Thanks, merged. |
|
thanks! would you mind tagging a new release? |
| type: predis | ||
| alias: default | ||
| dsn: | ||
| - redis://localhost |
There was a problem hiding this comment.
Are these sentinel hosts or redis hosts? What about port? Does the replication: sentinel setting automatically use port 26379 on those hostnames?
|
Could you tag a new release? @snc |
|
For anyone subscribed to this I see that a new release was tagged 8 days ago that includes this. |
I would like to use this bundle with a sentinel setup. This pull request allows setting the replication option to 'sentinel' and allows setting the 'service' option.
related to #274