Change configuration to allow config values required for redis sentinel

[pascal-hofmann]

This allows for supplying the required values for redis sentinel (supported by Predis 1.1.x, out soon). See predis/predis#131 (comment) . Unfortunately the password is somehow not used when connecting to the redis master. After hours of debugging I worked around this by creating a very hacky custom connection factory (at the moment I simply have no time for a proper solution. Maybe someone else has...):

class ConnectionFactory extends \Snc\RedisBundle\Client\Predis\Connection\ConnectionFactory
{
    private $masterPassword = null;

    public function create($parameters)
    {
        if (isset($parameters['parameters']['password'])) {
            $this->masterPassword = $parameters['parameters']['password'];
        }
        if ((int) $parameters['port'] === 6379) {
            $parameters['password'] = $this->masterPassword;
        }

        return parent::create($parameters);
    }

}

[AlexC]

@phofmann-trust What was your snc_redis config to allow support for Sentinels? From what I can see, whilst Predis now supports Sentinel, SncRedisBundle does not

[pascal-hofmann]

Did this for my old job. Don't have access to working configuration/source code anymore. Sorry :(

I remember that I had to do some other magic to get fully working Sentinel support with SncRedisBundle (some kind of config provider hack? Hm...)

thumbtyped, please excuse brevity and typos

Am 20.07.2016 um 17:32 schrieb Alex Cartwright notifications@github.com:

@phofmann-trust What was your snc_redis config to allow support for Sentinels? From what I can see, whilst Predis now supports Sentinel, SncRedisBundle does not

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[ivoba]

+1 for sentinel support

i worked around this with overriding the predis client service definitions in production since the main benefit of this bundle for me is logging & webprofiler, thus dev things which can be omitted in production.

snc_redis.default:
        class: Predis\Client
        arguments: ['%live.redis.sentinels%', '%live.default.redis.options%']

[asev]

+1 for redis sentinel support

[pascal-hofmann]

Closing this because it is now supported with version 2.