Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection via TLS (rediss) broken since 2.1.4 #444

Closed
lucasvanlierop opened this issue Jul 24, 2018 · 2 comments
Closed

Connection via TLS (rediss) broken since 2.1.4 #444

lucasvanlierop opened this issue Jul 24, 2018 · 2 comments
Labels
bug Not working as intended predis Specific to Predis

Comments

@lucasvanlierop
Copy link

v2.1.4 introduced a new way of parsing the dsn via \Snc\RedisBundle\DependencyInjection\Configuration\RedisDsn. It seems to discard the rediss:// scheme which results in an dsn with the tcp:// scheme rather than the expected tls:// scheme.

We (me and @jankramer) already took a quick look on fixing it by setting the scheme in the RedisDsn and retrieving it later on when building the dsn but we would first like to hear if you have a prefered way of fixing this.

FYI: We are using the Predis client which, in contrary to PHPRedis, supports TLS

@curry684 curry684 added bug Not working as intended predis Specific to Predis labels Jul 24, 2018
@B-Galati
Copy link
Collaborator

Thank you!

If the logic stays in the parseUrl method, it would be a good way of fixing it IMHO

@lucasvanlierop
Copy link
Author

Fixed by #445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Not working as intended predis Specific to Predis
Projects
None yet
Development

No branches or pull requests

3 participants