Use semver for PHP version at composer.json, added support for PHP 7.3 at Travis
#508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansys
force-pushed
the
travis
branch
3 times, most recently
from
d5905d1
to
0594082
Compare
|
See my comment #505 (comment) |
|
I can keep the move of |
|
@phansys You're right ;-) Thanks! |
phansys
force-pushed
the
travis
branch
3 times, most recently
from
d90d52c
to
a2fec55
Compare
|
Great! Updated the changes to only cover these concerns. |
B-Galati
approved these changes
Mar 18, 2019
|
Thanks @phansys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhpredisClientFactoryTestwas moved underTestsnamespace, andtestCreateFullConfig()test is marked with "redis4" group in order to be excluded at CI builds with Redis 4 (see #399).