Make logging with phpredis working again #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostrolucky
force-pushed
the
phpredis-logging
branch
from
351ec9a
to
ee67cad
Compare
ostrolucky
changed the title
ostrolucky
force-pushed
the
phpredis-logging
branch
2 times, most recently
from
ea13a78
to
11f2a14
Compare
|
@curry684 can this get some attention pls? 😊 |
|
Seems good to me. |
curry684
approved these changes
Oct 4, 2021
|
How could we trigger a new pipeline? |
ostrolucky
force-pushed
the
phpredis-logging
branch
from
11f2a14
to
49679e1
Compare
|
Triggered. Looks like we undiscovered unrelated issue with user/pw config not working in non-dsn format. |
ostrolucky
force-pushed
the
phpredis-logging
branch
6 times, most recently
from
619ca6b
to
4ff4057
Compare
ostrolucky
force-pushed
the
master
branch
12 times, most recently
from
f65da9c
to
37ba1bd
Compare
ostrolucky
force-pushed
the
phpredis-logging
branch
from
4ff4057
to
fe9357d
Compare
This was disabled in snc#405 but original reason stopped being valid after snc@37e2b50
ostrolucky
force-pushed
the
phpredis-logging
branch
from
fe9357d
to
b2d3b7d
Compare
This was referenced Oct 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was disabled in #405 but original reason stopped being valid after 37e2b50
Fixes #617