minify metadata.py to reduce package size #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generated link: snehilvj/dash-mantine-components-347 |
1 task
alexcjohnson
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
💃 But then if plotly/dash#3034 is merged and released we can remove this step here
|
@alexcjohnson, this would introduce a dependency on the dash version for building? |
|
Yes, but since that only applies to the one dev making the release it shouldn’t be a problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #271
This PR reduces the size of the metadata.json from 5.5MB to 3.0MB 🎉
minify_metadata.pyto reduce the file sizedistscript to runminify_metadata.pybefore creating the source distributionrelease.mdfile so I remember how do to this when making a release 😛