Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve overview aa1 to implement 1 #122

Merged
merged 12 commits into from
Aug 8, 2020
Merged

Improve overview aa1 to implement 1 #122

merged 12 commits into from
Aug 8, 2020

Conversation

pinterid
Copy link
Member

@pinterid pinterid commented Aug 7, 2020 •
edited by schettn
Loading

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change which adds documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

What is the new behavior (if this is a feature change)?

Other information:

  • 🐍

pinterid added 7 commits August 7, 2020 10:51
@pinterid
Update versions file
4537036 
The versions file was updated because of an damaged package.
@pinterid
Update package.json
9f81ba8 
The package.json was updated to use the latest versions of the required packages.
@pinterid
Update software tabs
bd4b0b6 
Software tabs are now no longer selectable.
@pinterid
Update badges
3482741 
The content of badges is now no longer selectable.
@pinterid
Add show more
c5732c5 
It is now possible to collapse the programming languages list.
@pinterid
Update latest activity
16929ad 
The latest activity now refreshes after re-caching.
@pinterid
Update 3D calendar
a1aee46 
The total contributions of the 3D calendar now change depending on the selected year.
@pinterid pinterid added the bug Something isn't working label Aug 7, 2020
@pinterid pinterid self-assigned this Aug 7, 2020
Aichnerc
Aichnerc approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member

@Aichnerc Aichnerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, found some things though.

src/components/atoms/charts/Calendar3D/index.jsx Outdated Show resolved Hide resolved
src/components/organisms/SoftwareTabs/softwaretabs.scss Outdated Show resolved Hide resolved
@pinterid
Improve Code Quality
abef6e4 
The code quality was improved due to a request by @Aichnerc.
@pinterid pinterid added the enhancement New feature or request label Aug 7, 2020
schettn
schettn requested changes Aug 7, 2020
View reviewed changes
Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look

package.json Show resolved Hide resolved
src/components/atoms/charts/LatestActivity/index.jsx Outdated Show resolved Hide resolved
@pinterid @schettn
Improve code quality
178bed8 
The code quality was improved due to a request by @schettn.

Co-authored-by: Schett Nico <52858351+schettn@users.noreply.github.com>
@pinterid pinterid requested a review from schettn August 7, 2020 09:39
schettn
schettn approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pinterid
Update Profile Information
8675a80 
The profile information is now displayed correctly.
@pinterid pinterid mentioned this pull request Aug 7, 2020
Merged
7 tasks
kleberbaum
kleberbaum requested changes Aug 7, 2020
View reviewed changes
Copy link
Member

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge after a few changes.

src/components/organisms/ProfileInfo/index.jsx Outdated Show resolved Hide resolved
@pinterid @kleberbaum
Improve code quality
30ffbce 
The code quality was improved due to a request by @kleberbaum.

Co-authored-by: Florian Kleber <kleberbaum@erebos.xyz>
@pinterid pinterid requested a review from kleberbaum August 7, 2020 11:17
kleberbaum
kleberbaum requested changes Aug 7, 2020
View reviewed changes
Copy link
Member

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge after a few changes.

src/components/organisms/ProfileInfo/index.jsx Outdated Show resolved Hide resolved
@pinterid @kleberbaum
Improve code quality
80e34a5 
The code quality was improved.

Co-authored-by: Florian Kleber <kleberbaum@erebos.xyz>
@pinterid pinterid requested a review from kleberbaum August 7, 2020 11:31
kleberbaum
kleberbaum approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge.

@schettn schettn added this to the SNEK Version 0.1.0 milestone Aug 7, 2020
@schettn schettn merged commit a232190 into implement-1 Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schettn schettn schettn approved these changes

@kleberbaum kleberbaum kleberbaum approved these changes

@Aichnerc Aichnerc Aichnerc approved these changes

Assignees

@pinterid pinterid

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
SNEK Version 0.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pinterid @Aichnerc @kleberbaum @schettn