Improve basics aa3 to implement 1 #74

pinterid · 2020-06-27T20:06:56Z

Checklist:

Have you added an explanation of what your changes do and why you'd like them to be included?
Have you updated or added documentation for the change?
Have you tested your changes with successful results?

Type of Changes:

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Documentation (non-breaking change which adds documentation)
Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

Currently the active tab of a software profile is not remembered. The active tab should be remembered #72
Currently the sign in button in the navigation bar redirects to the start page, but not directly to the sing in form. The navbar login button should redirect to the login form #73
Currently it is not possible to upload custom avatar images. There should be a way to upload a profile picture #76
Currently user settings can be changed via a modal. The settings modal should be changed to a settings page #77
Currently when recaching data the avatar image resets. The settings action does not support avatar url updates #78
Currently the application structure does not fit our needs because several issues. The application structure should be enhanced by using redux #80
Currently there is no notification when sining in fails. There should be a notification when something gone wrong when logging in #81
Currently the pinned repositories are kind of useless because they do not show any useful information. The pinned projects should be temporary disabled #82
Currently there are some issues in styling when displaying projects. There are some issues with displaying projects #83
Currently there is no language chart for projects. There should be a language chart for each project #84
Currently there is no default image for projects without an avatar image/owner. There should be a default image for projects without an avatar #85
Currently there is no language chart for a user. There should be a language chart in profile info #86
Currently a user cannot modify the position of charts on his own overview page. There should be a editor mode for the overview tab #88
Currently the design seems a bit outdated and there are several minor issues. The design should be improved #90

What is the new behavior (if this is a feature change)?

Now the active tab of a software profile is remembered. The active tab should be remembered #72
Now the navbar login button redirects to the login form. The navbar login button should redirect to the login form #73
Now it is possible to upload custom avatar images. There should be a way to upload a profile picture #76
Now user settings can be changed via a separate settings page. The settings modal should be changed to a settings page #77
Now when uploading a avatar image it is permanent. The settings action does not support avatar url updates #78
Now redux is implemented which resolves issues like active tabs when state changes,.. The application structure should be enhanced by using redux #80
Now when singing in fails there is a notification in the login form. There should be a notification when something gone wrong when logging in #81
Now the pinned repositories are temporary disabled. The pinned projects should be temporary disabled #82
Now the styling of projects is refined and also works fine with projects without an owner. There are some issues with displaying projects #83
Now there is a language chart for each project. There should be a language chart for each project #84
Now there is a default image for projects without a an avatar/owner. There should be a default image for projects without an avatar #85
Now there is a language chart on each user profile. There should be a language chart in profile info #86
Now a user can modify the position of charts on his own overview page. There should be a editor mode for the overview tab #88
Now the design is more rounded and improved in general. Project styling, navbar styling,.. has been updated. The design should be improved #90

Other information:

Ref: 🐍

The active object was added to globalState.

The active software tab is now stored in the new globalState.

The active actionCard is now stored in the new globalState.

The navbar login button now sets the active actionCard.

Aichnerc

LGTM

With the introduced implementation it is possible to use the "Sign In" button to redirect to the correct login action card. The workaround which allows reloading the last tab before caching remounts every component is removed now. The functionality which is missing now will be added soon.

New redux structure was roughly implemented. Refinements take place in the following commits. But .. redux is fun :)

Some bugs are fixed and the actions were adjusted.

Incorrect user fetching has been fixed.

The registration works now with the new structure.

A context error where the login function was not defined due to asynchronously is fixed now. After registering a user will be logged in.

React-Avatar-Editor was added for editing images on the site.

The modal for editing images was added.

The modal imports and exports were updated.

A page for editing user settings was added.

The path for the settings page was set.

The navbar settings now work with the settings page.

The settings action is now capable of updating profile pictures.

Now it is possible to access the settings page directly by entering the url. Access is only granted to the own settings page.

Now when clicking on `My Profile` only the corresponding components are rendered and not longer everyone like before.

Due to the switch to Redux, a lot of code is obsolete and is now being removed.

None has been replaced with Unknown in the project item.

If there is no owner for a project, the new owner is unknown.

The loading bar styling, which was previously accidentally removed, is now available again. This will show the loading bar again.

Add movable aa1 to improve basics aa3

Some scss stuff has been fixed due to a codacy request.

Co-authored-by: Aichner Christian <contact@aichner-christian.com>

Improve design ca1 to improve basics aa3

@Aichnerc

The code quality has been improved due to request of @Aichnerc @pinterid @kleberbaum.

Due to a merging problem the talk upload modal did not use redux and therefore did not work anymore. Redux was added in order to get it back working.

Aichnerc

Found a few things.

src/App.js

src/components/molecules/Footer/index.jsx

src/components/molecules/Navbar/index.jsx

src/store/actions/generalActions.js

@Aichnerc

The code quality has been improved due to a reuqest of @Aichnerc.

Aichnerc

LGTM 🍕

Now when reading the cache the loggedUser is set with fetchUser data if the read user is the same as the loggedUser.

kleberbaum

Should be ok to merge after a few changes.

src/components/organisms/tabs/TalksTab/index.jsx

src/components/pages/ProfilePage/index.jsx

src/components/pages/ProfilePage/profile.scss

kleberbaum · 2020-07-09T07:18:09Z

src/index.js

+const INTEL = new Intel();
+
+//#TODO
+// Must be moved to INTEL in future?


Mhh, good question should be part of a meeting.

src/index.js

src/store/reducers/index.js

src/components/atoms/SearchBar/index.jsx

src/components/molecules/Navbar/index.jsx

@kleberbaum

The code quality has been improved due to a request of @kleberbaum.

schettn

Yep

kleberbaum

Should be ok to merge.

pinterid added 4 commits June 27, 2020 22:00

Update globalState

be3b9f8

The active object was added to globalState.

Implement active tab

0bc78b8

The active software tab is now stored in the new globalState.

Implement active action card

c696cd8

The active actionCard is now stored in the new globalState.

Update navbar login

421da95

The navbar login button now sets the active actionCard.

pinterid added the enhancement New feature or request label Jun 27, 2020

pinterid added this to the SNEK Version 0.1.0 milestone Jun 27, 2020

pinterid requested review from Aichnerc, kleberbaum, simonprast and schettn June 27, 2020 20:06

pinterid self-assigned this Jun 27, 2020

Aichnerc approved these changes Jun 27, 2020

View reviewed changes

schettn and others added 16 commits June 30, 2020 22:10

Upgrade to redux

27705e4

New redux structure was roughly implemented. Refinements take place in the following commits. But .. redux is fun :)

Enhance Redux

bd269f8

Some bugs are fixed and the actions were adjusted.

Improve user fetching

1c6a968

Incorrect user fetching has been fixed.

Upgrade registration component with redux

6b0ca3f

The registration works now with the new structure.

Login after regisration

6455e6c

A context error where the login function was not defined due to asynchronously is fixed now. After registering a user will be logged in.

Update package.json

4548fd0

React-Avatar-Editor was added for editing images on the site.

Add profile picture modal

cf9f25d

The modal for editing images was added.

Update modal export/imports

63d488c

The modal imports and exports were updated.

Add settings page

3fdfaeb

A page for editing user settings was added.

Implement settings page

1c7d15b

The path for the settings page was set.

Update navbar settings

11ce7b8

The navbar settings now work with the settings page.

Update settings action

8b65ce7

The settings action is now capable of updating profile pictures.

Improve settings page accesability

42f6728

Now it is possible to access the settings page directly by entering the url. Access is only granted to the own settings page.

Improve user menu

4d9268d

Now when clicking on `My Profile` only the corresponding components are rendered and not longer everyone like before.

Remove legacy code

0332ee5

Due to the switch to Redux, a lot of code is obsolete and is now being removed.

Aichnerc and others added 10 commits July 8, 2020 18:48

Improve wording

8469dc0

None has been replaced with Unknown in the project item.

Improve stability

0034279

If there is no owner for a project, the new owner is unknown.

Re-add loading bar styling

f20e71c

The loading bar styling, which was previously accidentally removed, is now available again. This will show the loading bar again.

Merge pull request #89 from snek-at/add-movable-aa1

d71bb28

Add movable aa1 to improve basics aa3

Merge branch 'improve-basics-aa3' into improve-design-ca1

98302bf

Improve code quality

d2d0e08

Some scss stuff has been fixed due to a codacy request.

Apply suggestions from code review

c01d1d6

Co-authored-by: Aichner Christian <contact@aichner-christian.com>

Apply suggestions from code review

2e6d448

Merge pull request #91 from snek-at/improve-design-ca1

bfd64b3

Improve design ca1 to improve basics aa3

Improve code quality

bc0eb01

The code quality has been improved due to request of @Aichnerc @pinterid @kleberbaum.

schettn requested review from Aichnerc and kleberbaum July 8, 2020 19:17

schettn assigned Aichnerc and schettn Jul 8, 2020

Upgrade TalkUploadModal with Redux

427b3d2

Due to a merging problem the talk upload modal did not use redux and therefore did not work anymore. Redux was added in order to get it back working.

Aichnerc requested changes Jul 8, 2020

View reviewed changes

src/App.js Outdated Show resolved Hide resolved

src/components/molecules/Footer/index.jsx Outdated Show resolved Hide resolved

src/components/molecules/Navbar/index.jsx Outdated Show resolved Hide resolved

src/store/actions/generalActions.js Show resolved Hide resolved

Improve code quality

068d3d4

The code quality has been improved due to a reuqest of @Aichnerc.

schettn requested a review from Aichnerc July 8, 2020 19:58

Aichnerc approved these changes Jul 8, 2020

View reviewed changes

Add loggedUser Object on Read Cache

d52b5d2

Now when reading the cache the loggedUser is set with fetchUser data if the read user is the same as the loggedUser.

kleberbaum requested changes Jul 9, 2020

View reviewed changes

Improve code quality

0a0104f

The code quality has been improved due to a request of @kleberbaum.

schettn requested a review from kleberbaum July 9, 2020 08:39

schettn approved these changes Jul 9, 2020

View reviewed changes

kleberbaum approved these changes Jul 9, 2020

View reviewed changes

Aichnerc removed the request for review from simonprast July 9, 2020 09:13

Aichnerc merged commit 867d119 into implement-1 Jul 9, 2020

pinterid mentioned this pull request Jul 13, 2020

Implement 1 to master #52

Open

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve basics aa3 to implement 1 #74

Improve basics aa3 to implement 1 #74

pinterid commented Jun 27, 2020 •

edited by schettn

Loading

Aichnerc left a comment

Aichnerc left a comment

Aichnerc left a comment

kleberbaum left a comment

kleberbaum Jul 9, 2020

schettn left a comment

kleberbaum left a comment

Improve basics aa3 to implement 1 #74

Improve basics aa3 to implement 1 #74

Conversation

pinterid commented Jun 27, 2020 • edited by schettn Loading

Aichnerc left a comment

Choose a reason for hiding this comment

Aichnerc left a comment

Choose a reason for hiding this comment

Aichnerc left a comment

Choose a reason for hiding this comment

kleberbaum left a comment

Choose a reason for hiding this comment

kleberbaum Jul 9, 2020

Choose a reason for hiding this comment

schettn left a comment

Choose a reason for hiding this comment

kleberbaum left a comment

Choose a reason for hiding this comment

pinterid commented Jun 27, 2020 •

edited by schettn

Loading