Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Python 3.4 #28

Merged

Conversation

jcbrockschmidt
Copy link
Collaborator

Python 3.4 support has been removed in the latest versions of tox, as seen here.

Attempting to run tox 3.20.1 on better_profanity outputs the following log for the py34 tests:

ERROR: invocation failed (exit code 1), logfile: <OMITTED>/better_profanity/.tox/py34/log/py34-11.log
=============================== log start ================================
Traceback (most recent call last):
  File "/usr/lib/python3.4/runpy.py", line 170, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.4/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/mnt/linux_storage/joshypoo/Projects/better_profanity/.tox/py34/lib/python3.4/site-packages/pip/__main__.py", line 16, in <module>
    from pip._internal.cli.main import main as _main  # isort:skip # noqa
  File "/mnt/linux_storage/joshypoo/Projects/better_profanity/.tox/py34/lib/python3.4/site-packages/pip/_internal/cli/main.py", line 10, in <module>
    from pip._internal.cli.autocompletion import autocomplete
  File "/mnt/linux_storage/joshypoo/Projects/better_profanity/.tox/py34/lib/python3.4/site-packages/pip/_internal/cli/autocompletion.py", line 9, in <module>
    from pip._internal.cli.main_parser import create_main_parser
  File "/mnt/linux_storage/joshypoo/Projects/better_profanity/.tox/py34/lib/python3.4/site-packages/pip/_internal/cli/main_parser.py", line 7, in <module>
    from pip._internal.cli import cmdoptions
  File "/mnt/linux_storage/joshypoo/Projects/better_profanity/.tox/py34/lib/python3.4/site-packages/pip/_internal/cli/cmdoptions.py", line 24, in <module>
    from pip._internal.exceptions import CommandError
  File "/mnt/linux_storage/joshypoo/Projects/better_profanity/.tox/py34/lib/python3.4/site-packages/pip/_internal/exceptions.py", line 10, in <module>
    from pip._vendor.six import iteritems
  File "/mnt/linux_storage/joshypoo/Projects/better_profanity/.tox/py34/lib/python3.4/site-packages/pip/_vendor/__init__.py", line 79, in <module>
    vendored("pkg_resources")
  File "/mnt/linux_storage/joshypoo/Projects/better_profanity/.tox/py34/lib/python3.4/site-packages/pip/_vendor/__init__.py", line 36, in vendored
    __import__(modulename, globals(), locals(), level=0)
  File "/mnt/linux_storage/joshypoo/Projects/better_profanity/.tox/py34/lib/python3.4/site-packages/pkg_resources/__init__.py", line 92, in <module>
    raise RuntimeError("Python 3.5 or later is required")
RuntimeError: Python 3.5 or later is required

================================ log end =================================

The alternative seems to be using an older version of tox indefinitely.

Copy link
Owner

@snguyenthanh snguyenthanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think it's time to drop support for Python 3.4

@jcbrockschmidt jcbrockschmidt merged commit c371cf6 into snguyenthanh:master Sep 26, 2021
@jcbrockschmidt jcbrockschmidt deleted the remove-py34-support branch September 26, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants