Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Data Bar in Service Details page not shown correctly. #1158

Open
ChristianSchoeniger opened this issue Feb 7, 2022 · 2 comments

Comments

@ChristianSchoeniger
Copy link

Describe the bug

  • background of bar doesn't reflect service state when there is more than one perforrmance data value
  • if there are ranges for Warning/Critical values the bar doesn't shown any data

Thruk Version
Thruk 2.46.3

To Reproduce
Steps to reproduce the behavior:

  1. Go to a Service with more than 1 perforrmance data value

  2. See error

  3. Go to a Service with ranges for Warning/Critical values

  4. See error

Expected behavior
see attached screenshots

Screenshots
multiple performance data values:
raw data = "pages=32773 'TK-8335C'=26%;10;3;0;100 'TK-8335M'=37%;10;3;0;100 'TK-8335Y'=7%;10;3;0;100 'TK-8335K'=18%;10;3;0;100"

thruk_service_perf_data_bar_2

Warning/Critical range:
raw data = "51_TX=-4.89dBm;-15:-1;-16:0.01 51_RX=-11.18dBm;-15:-1;-16:0.01 52_TX=-4.93dBm;-15:-1;-16:0.01 52_RX=-6.02dBm;-15:-1;-16:0.01"

thruk_service_perf_data_bar_1

Patched
multiple performance data values:
Hard to see, but the bar for the value that triggers the warning is yellow.
thruk_service_perf_data_bar_2_patched

Warning/Critical range:
thruk_service_perf_data_bar_1_patched
thruk_service_perf_data_bar_3_patched

Additional context
How can i submit my patch?

ChristianSchoeniger added a commit to ChristianSchoeniger/Thruk that referenced this issue Feb 7, 2022
@sni
Copy link
Owner

sni commented Feb 7, 2022

The idea is, that if there are multiple performance values, then only the ones which are outside their range should have the background color set. For example take check_disk over all filesystems and only one is full. It would make no sense to draw all of them with a red background.
But from a quick look, that's still the case with your patch, right? You should be able to create a pull request from your fork. There should be a button somewhere :)

@ChristianSchoeniger
Copy link
Author

ChristianSchoeniger commented Feb 8, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants