Issue with DataTables for empty anchor links

[furiabhavesh]

I have a page which consists of User list on left side and its details appearing on right side on click of username. The details section is a form(being checked for dirty) which admin can change.

The problem is, on left hand side I have userlist in a DataTables with pagination feature. So now if I am adding values for new user which makes the form dirty and click on DataTables's pagination links (Next or Previous) before saving the user record, the dirtyForm warning is shown properly. If I click on "Continue" the page redirects to "/undefined". I found this thing when I enabled the dirtyLog.

According to me, its happening because the prev-next buttons in datatables are anchor tags without any "href" attribute whose value is being used by dirtyForms before showing the "Continue" - "Stop" popup.

I have fixed this thing for now by just checking for undefined value by replacing below line in jquery.dirtyforms.js file

location.href = anchor.attr('href');

with

if (anchor.attr('href')!=undefined) {
  location.href = anchor.attr('href');
}

[furiabhavesh]

Like above situation, I have so many anchor links for various purpose with no "href" values.

Eg: - I have a requirement where I dont want to show dirtyForm warning if user presses "Cancel" link on form.

I am ignoring dirtyForms popup on click of cancel link as follows.

function skip_dirty_form_check_on_cancel(){
  $(".dirtyCancel").click(function(){
    $("form.jq-validate").removeClass("dirty");
  });
}

Is there any better way to achieve above thing because I have more than 1 element for which I want to ignore dirtyForm warning and I dont want my above code to look like below

$(".dirtyCancel, #el1, #el2, #el3_and_so_on").click(function(){
........
});

[snikch]

If you can create a pull request for the fix with links with no href, that would be great. As for the cancel links etc. if you add the class ignoreDirty (you can modify that in the settings), then those links should be ignored.

[furiabhavesh]

Pull request created here

[furiabhavesh]

@snikch : Is there any issue in the pull request ? Its been long time now

[snikch]

Sorry @furiabhavesh, that's completely my laziness. Thanks for reminding me – I've merged the pull request!

[furiabhavesh]

Thanks @snikch