-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add primary keys to tables that are missing them #9359
Conversation
Some mysql clusters (like Percona-XtraDB-Cluster) prohibit the use of DML commands on a table. It's also just a good practice to add it.
💖 Thanks for this pull request! 💖 We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can retarget these changes to the Develop branch, we'll take them.
I’m still kind of unclear what problem this solves, exactly? |
Some mysql clusters (like Percona-XtraDB-Cluster) prohibit the use of DML commands on a table. It's also just a good practice to add it. See laravel/framework#15770
Some mysql clusters (like Percona-XtraDB-Cluster) prohibit the use of DML commands on a table. It's also just a good practice to add it.
Some database systems (like XtraDB cluster) require explicit primary keys for all tables, so this PR adds them to those that are missing them. I'm closing this one and created a new one for develop: #9363 |
Description
Adds primary keys to tables where they are missing.
See See laravel/framework#15770 for a thorough explanation and more context.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested on our environment where the migrations table was missing the
id
column (shows you we've been using this since at least 2016 😅 ) and with the default database you get when installing snipe itChecklist: