Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use creating the wrong translator factory #200

Closed
plastikfan opened this issue Mar 30, 2023 · 1 comment
Closed

Use creating the wrong translator factory #200

plastikfan opened this issue Mar 30, 2023 · 1 comment
Assignees
@plastikfan
Labels
bug Something isn't working

Comments

@plastikfan
Copy link
Contributor

When a client calls Use, extendio only ever creates a SingularTranslatorFactory (in applyLanguage). Rather it should look in the UseOptions and only create a SingularTranslatorFactory if there are no user specified sources and create a MultiTranslatorFactory in all other scenarios.
@plastikfan plastikfan added the bug Something isn't working label Mar 30, 2023
@plastikfan plastikfan self-assigned this Mar 30, 2023
@plastikfan plastikfan changed the title allow client to specify additional sources when calling Use Use creating the wrong correct translator factory Mar 30, 2023
@plastikfan plastikfan changed the title Use creating the wrong correct translator factory Use creating the wrong translator factory Mar 30, 2023
@plastikfan
Copy link
Contributor Author

the lint pre commit hook had to be disabled and needs to be fixed in another issue.

plastikfan added a commit that referenced this issue Mar 31, 2023
@plastikfan
fix(i18n): use the correct translator factory (#200)
e6fae2f
plastikfan added a commit that referenced this issue Mar 31, 2023
@plastikfan
fix(i18n): use the correct translator factory (#200)
2f927d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plastikfan plastikfan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@plastikfan