Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change Use to be incremental #233

Closed
plastikfan opened this issue Apr 23, 2023 · 0 comments · Fixed by #235
Closed

change Use to be incremental #233

plastikfan opened this issue Apr 23, 2023 · 0 comments · Fixed by #235
Assignees
@plastikfan
Labels
bug Something isn't working

Comments

@plastikfan
Copy link
Contributor

plastikfan commented Apr 23, 2023 •
edited
Loading

When a client calls Use specifying sources, Use should add those sources to the existing ones. This will allow unit tests to override the sources that clients provide.

applyLanguage needs to be changed to provide this incremental functionality:

	tx = factory.New(lang)
	TxRef = utils.NewRoProp(tx)
@plastikfan plastikfan added the bug Something isn't working label Apr 23, 2023
@plastikfan plastikfan self-assigned this Apr 23, 2023
plastikfan added a commit that referenced this issue Apr 24, 2023
@plastikfan
fix(i18n): make use incremental (#233)
cbb5fdd
@plastikfan plastikfan linked a pull request Apr 24, 2023 that will close this issue
fix(i18n): make use incremental (#233) #235
Merged
plastikfan added a commit that referenced this issue Apr 24, 2023
@plastikfan
fix(i18n): make use incremental (#233)
76c5e0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plastikfan plastikfan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(i18n): make use incremental (#233) snivilised/extendio
1 participant
@plastikfan