Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unhandled exception raised at runtime: 'x-ratelimit-remaining' #58

Merged
merged 6 commits into from
Aug 5, 2023

Conversation

den-is
Copy link
Contributor

@den-is den-is commented Mar 13, 2023

Fixing #57

P.S.: My default black config formatted code a little bit.

Signed-off-by: Denis Iskandarov <d.iskandarov@gmail.com>
Signed-off-by: Denis Iskandarov <d.iskandarov@gmail.com>
@JonasKs
Copy link
Member

JonasKs commented Mar 13, 2023

Hi 😊 Thanks for the PR.

P.S.: My default black config formatted code a little bit.

It's already implemented black in this project (see the failing linting pipeline), but our config differs from yours. It's used through pre-commit. Simply write pre-commit install in your repo, and then pre-commit run --all-files and it'll be fixed. (Require you to install pre-commit first)

Signed-off-by: Denis Iskandarov <d.iskandarov@gmail.com>
@sondrelg
Copy link
Member

sondrelg commented Aug 4, 2023

This looks good to me. Just curious @den-is, have you had a chance to test this version of the code on your own projects? I've migrated my images to ECR, so no longer have a real project to try things like this on hehe 🤷

@den-is
Copy link
Contributor Author

den-is commented Aug 5, 2023

This looks good to me. Just curious @den-is, have you had a chance to test this version of the code on your own projects? I've migrated my images to ECR, so no longer have a real project to try things like this on hehe 🤷

Yes, it was/is successfully working for months on a scheduled basis.
But action/execution still was hitting GH rate-limits, Looks like this async code requires some "semaphores". While it was hitting GH rate-limits it still was doing its job and was cleaning the registry.

I'm not working on that project and don't have access to such GHCR anymore.

@sondrelg
Copy link
Member

sondrelg commented Aug 5, 2023

OK sounds good. I'll try and get this released now! 👍

@sondrelg sondrelg merged commit fdad324 into snok:main Aug 5, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants