Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key Error #116

Closed
Seykotron opened this issue Nov 25, 2020 · 3 comments
Closed

Key Error #116

Seykotron opened this issue Nov 25, 2020 · 3 comments
Labels
bug

Comments

@Seykotron
Copy link
Contributor

If some user has no UPN there raises an error, the code should check if that claim exist's before try to asign it as an Username

https://github.com/jobec/django-auth-adfs/blob/93bcb3ff262ae92b3bae2858a34fb09977f9a9a4/django_auth_adfs/backend.py#L123

Thank you!
@JonasKs
Copy link
Member

JonasKs commented Jan 13, 2021

Agree. Would you like to raise a PR?

@Seykotron
Copy link
Contributor Author

Yes, im a bit bussy right now, but I can raise a PR yep, proud to take part of this proyect 👍

@JonasKs
Copy link
Member

JonasKs commented Jan 13, 2021 •
edited
Loading

Awesome. 🎉 Let me know if you need any help!

@JonasKs JonasKs added the bug label Jan 16, 2021
Seykotron added a commit to Seykotron/django-auth-adfs that referenced this issue Mar 23, 2021
@Seykotron
snok#116 Fixed
c9a69f5
JonasKs added a commit that referenced this issue Mar 25, 2021
@JonasKs
Merge pull request #149 from Seykotron/master
87237a4 
#116 Raise PermissionDenied when token is lacking information needed to create a user.
mmcclelland1002 pushed a commit to mmcclelland1002/django-auth-adfs that referenced this issue Nov 12, 2021
@Seykotron
snok#116 Fixed
42db44b
mmcclelland1002 pushed a commit to mmcclelland1002/django-auth-adfs that referenced this issue Nov 12, 2021
@Seykotron
Fixed snok#116
0568864
mmcclelland1002 pushed a commit to mmcclelland1002/django-auth-adfs that referenced this issue Nov 12, 2021
@JonasKs
Merge pull request snok#149 from Seykotron/master
421de2a 
snok#116 Raise PermissionDenied when token is lacking information needed to create a user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Seykotron @JonasKs