Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependency on and compatibility with PyJWT 2.0 #120

Merged
merged 2 commits into from
Jan 15, 2021
Merged

Add dependency on and compatibility with PyJWT 2.0 #120

merged 2 commits into from
Jan 15, 2021

Conversation

SanderTuit
Copy link
Contributor

Fixes #118

@SanderTuit
Copy link
Contributor Author

As far as I remember, this is the first pull request I created on a public project. So if there's anything wrong, please let me know. The Travis tests all seem to fail, because PyJWT 2.0.0 is not found. However 2.0.0 was released on december 22. I'm not sure if there's a cache that should be emptied or a package index that can be refreshed.

@JonasKs JonasKs mentioned this pull request Jan 14, 2021
Closed
@JonasKs
Copy link
Member

JonasKs commented Jan 14, 2021

Hi! That’s awesome, happy you’re on the “dark side” with us 😉 Looks good. I’ll just verify locally before I merge, but I’ll do that today.

As for people waiting for this PR to be merged @ingvaldlorentzen has provided a work around in #118

This was referenced Jan 14, 2021
Closed
Closed
@JonasKs
Copy link
Member

JonasKs commented Jan 14, 2021

Sorry, busy day. I’ll hopefully have time tomorrow, and if not I’ll 100% have time this weekend.

JonasKs
JonasKs reviewed Jan 15, 2021
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@JonasKs
Copy link
Member

JonasKs commented Jan 15, 2021

Perfect, thank you @SanderTuit !

I'll have to do a few things before I can publish this to PyPI, but it'll happen on Saturday.

@JonasKs JonasKs merged commit 03deea0 into snok:master Jan 15, 2021
@JonasKs
Copy link
Member

JonasKs commented Jan 16, 2021

1.4.0 has been released to PyPI.

@JonasKs JonasKs mentioned this pull request Jun 8, 2021
Closed
mmcclelland1002 pushed a commit to mmcclelland1002/django-auth-adfs that referenced this pull request Nov 12, 2021
@JonasKs
Merge pull request snok#120 from SanderTuit/upgrade-pyjwt-dependency
3acec34 
Add dependency on and compatibility with PyJWT 2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasKs JonasKs JonasKs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PyJWT 2.0 not compatible
2 participants
@SanderTuit @JonasKs