Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom error handler #136

Merged
merged 15 commits into from
Jan 25, 2021
Merged

Custom error handler #136

merged 15 commits into from
Jan 25, 2021

Conversation

peterfarrell
Copy link
Contributor

Closes #112

@codecov
Copy link

codecov bot commented Jan 21, 2021 •
edited
Loading

Codecov Report

Merging #136 (70e47fe) into master (2ecce35) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master    #136     +/-   ##
========================================
+ Coverage    82.9%   83.0%   +0.1%     
========================================
  Files           8       8             
  Lines         427     431      +4     
========================================
+ Hits          354     358      +4     
  Misses         73      73
Impacted Files Coverage Δ
django_auth_adfs/config.py 85.7% <100.0%> (+0.2%) ⬆️

@peterfarrell peterfarrell marked this pull request as ready for review January 21, 2021 22:27
@peterfarrell peterfarrell mentioned this pull request Jan 21, 2021
Closed
@JonasKs
Copy link
Member

JonasKs commented Jan 22, 2021

Thank you! I'll review this weekend. 🍺

JonasKs
JonasKs requested changes Jan 24, 2021
View reviewed changes
Copy link
Member

@JonasKs JonasKs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things 🎉

tests/views.py Show resolved Hide resolved
docs/settings_ref.rst Outdated Show resolved Hide resolved
django_auth_adfs/config.py Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
JonasKs
JonasKs reviewed Jan 24, 2021
View reviewed changes
docs/settings_ref.rst Outdated Show resolved Hide resolved
@peterfarrell
Copy link
Contributor Author

@JonasKs Updated per review notes. Updated date in doco to 2021-01-25. Ready for merge and release.

@JonasKs
Copy link
Member

JonasKs commented Jan 25, 2021

Thank you! 🎉

JonasKs
JonasKs reviewed Jan 25, 2021
View reviewed changes
CHANGELOG.rst Outdated Show resolved Hide resolved
@peterfarrell @JonasKs
Update CHANGELOG.rst
ed01c29 
Co-authored-by: Jonas Krüger Svensson <jonas-ks@hotmail.com>
@JonasKs
Copy link
Member

JonasKs commented Jan 25, 2021

I'm so sorry, this has been a lot back and forth - that's how it is when I review after a long day. 😄

Could you bump to 1.6.0? This is a feature release.

@peterfarrell
Copy link
Contributor Author

@JonasKs Bumped to 1.6.0 I think I got all the places (init.py, project.toml, and changelog).

@JonasKs JonasKs merged commit 7c12aac into snok:master Jan 25, 2021
@JonasKs
Copy link
Member

JonasKs commented Jan 25, 2021

Thank you, @peterfarrell !

It's been released: https://github.com/snok/django-auth-adfs/runs/1764282538?check_suite_focus=true

https://pypi.org/project/django-auth-adfs/

@peterfarrell peterfarrell deleted the custom_error_handler branch January 25, 2021 19:01
mmcclelland1002 pushed a commit to mmcclelland1002/django-auth-adfs that referenced this pull request Nov 12, 2021
@JonasKs
Merge pull request snok#136 from atdsaa/custom_error_handler
2a3c5ed 
Custom error handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasKs JonasKs JonasKs approved these changes

Assignees

@peterfarrell peterfarrell

@JonasKs JonasKs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom failure handler?
2 participants
@peterfarrell @JonasKs