Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version setting and fix white space issue #160

Merged
merged 4 commits into from
Jun 7, 2021

Conversation

jatindergit
Copy link
Contributor

No description provided.

@jatindergit
Copy link
Contributor Author

@JonasKs i have raised a new pull request

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #160 (47d2f3c) into master (19a4b7b) will increase coverage by 0.1%.
The diff coverage is 87.5%.

@@           Coverage Diff            @@
##           master    #160     +/-   ##
========================================
+ Coverage    84.1%   84.3%   +0.1%     
========================================
  Files          11      11             
  Lines         486     492      +6     
========================================
+ Hits          409     415      +6     
  Misses         77      77             
Impacted Files Coverage Δ
django_auth_adfs/config.py 87.4% <87.5%> (+0.3%) ⬆️

@jatindergit
Copy link
Contributor Author

@JonasKs Please merge

@JonasKs
Copy link
Member

JonasKs commented May 12, 2021

I’m on vacation. This will probably have to wait until I’m back. 🏖️

@jatindergit
Copy link
Contributor Author

s will probably have to wait until I’m

When you are coming back

@JonasKs
Copy link
Member

JonasKs commented May 26, 2021

This looks good. 🎉 I'd love a test for the setting, though. Are you able to provide this, or do you want assistance?

@jatindergit
Copy link
Contributor Author

the sett

You can test it and please let me know if anything is needed

@JonasKs
Copy link
Member

JonasKs commented May 27, 2021

Alright, I'll look into this. Please ensure I have access to your branch (I think you can use a checkbox on this merge request to allow maintainers of this repo to edit your code, but if not, giving me directly access on your fork is an option)

@jatindergit
Copy link
Contributor Author

Allow edits by maintainers is already checked

@jatindergit
Copy link
Contributor Author

@JonasKs Please let know when you will do this. I really need this. This will be a great help if you do this asap. Thanks in advance :)

@JonasKs
Copy link
Member

JonasKs commented Jun 3, 2021

I'll try to do it today or tomorrow. :)

@JonasKs
Copy link
Member

JonasKs commented Jun 3, 2021

Please fix merge issues first.

Remember that it's always best to create feature branches and make PRs from them, instead of your own master.

@jatindergit
Copy link
Contributor Author

@JonasKs Done. Sorry I am doing this first time

@JonasKs
Copy link
Member

JonasKs commented Jun 3, 2021

No worries - only way to learn! 🎉 Unfortunately I won't have time tonight, but I'll probably have time tomorrow.

Edit: I didn’t.. Thought it was Thursday, turns out it’s Friday.

@JonasKs JonasKs merged commit 9492185 into snok:master Jun 7, 2021
@JonasKs
Copy link
Member

JonasKs commented Jun 7, 2021

Hi @jatindergit . I've written a few tests and did a few minor changes. I've also went ahead and merged the change.

Thank you for your contribution! 🎉

You can expect a new release today.

@JonasKs
Copy link
Member

JonasKs commented Jun 7, 2021

It's available as version 1.7.0 on PyPI now.

mmcclelland1002 pushed a commit to mmcclelland1002/django-auth-adfs that referenced this pull request Nov 12, 2021
Add version setting and fix white space issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants