-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version setting and fix white space issue #160
Conversation
@JonasKs i have raised a new pull request |
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
========================================
+ Coverage 84.1% 84.3% +0.1%
========================================
Files 11 11
Lines 486 492 +6
========================================
+ Hits 409 415 +6
Misses 77 77
|
@JonasKs Please merge |
I’m on vacation. This will probably have to wait until I’m back. 🏖️ |
When you are coming back |
This looks good. 🎉 I'd love a test for the setting, though. Are you able to provide this, or do you want assistance? |
You can test it and please let me know if anything is needed |
Alright, I'll look into this. Please ensure I have access to your branch (I think you can use a checkbox on this merge request to allow maintainers of this repo to edit your code, but if not, giving me directly access on your fork is an option) |
Allow edits by maintainers is already checked |
@JonasKs Please let know when you will do this. I really need this. This will be a great help if you do this asap. Thanks in advance :) |
I'll try to do it today or tomorrow. :) |
Please fix merge issues first. Remember that it's always best to create feature branches and make PRs from them, instead of your own master. |
@JonasKs Done. Sorry I am doing this first time |
No worries - only way to learn! 🎉 Unfortunately I won't have time tonight, but I'll probably have time tomorrow. Edit: I didn’t.. Thought it was Thursday, turns out it’s Friday. |
Hi @jatindergit . I've written a few tests and did a few minor changes. I've also went ahead and merged the change. Thank you for your contribution! 🎉 You can expect a new release today. |
It's available as version |
Add version setting and fix white space issue
No description provided.