Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation, tests and docs of pull request #104 #172

Merged
merged 2 commits into from
Aug 14, 2021

Conversation

joachimBurket
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #172 (7590bb5) into master (4917d37) will increase coverage by 1.0%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master    #172     +/-   ##
========================================
+ Coverage    84.3%   85.4%   +1.0%     
========================================
  Files          11      11             
  Lines         492     494      +2     
========================================
+ Hits          415     422      +7     
+ Misses         77      72      -5     
Impacted Files Coverage Δ
django_auth_adfs/backend.py 83.6% <100.0%> (+3.2%) ⬆️

@JonasKs
Copy link
Member

JonasKs commented Jul 30, 2021

Thank you!!
I'm out of town for a few days, but I'll check it when I get home. 🎉

@sondrelg , any comments?😊

@joachimBurket
Copy link
Contributor Author

@JonasKs ping ?

@JonasKs
Copy link
Member

JonasKs commented Aug 13, 2021

I'm sorry, I totally forgot about this.

I'll check it out tonight and release before the weekend.

@joachimBurket
Copy link
Contributor Author

No worry I also forgot it 😅
Thanks :)

@JonasKs
Copy link
Member

JonasKs commented Aug 13, 2021

Looks good to me! 🎉

Could you please bump version like we did here? Otherwise I'll have to wait until Monday to merge and release, but that's okay if you want to wait. 😊

@JonasKs JonasKs merged commit 70de1a2 into snok:master Aug 14, 2021
@JonasKs
Copy link
Member

JonasKs commented Aug 14, 2021

Thank you! Unfortunately I tagged the wrong PR (#104) instead of #172 in the release notes. I'm sorry about that.

@joachimBurket
Copy link
Contributor Author

No worry for the tag and thanks a lot for the release! :)

mmcclelland1002 pushed a commit to mmcclelland1002/django-auth-adfs that referenced this pull request Nov 12, 2021
Implementation, tests and docs of pull request snok#104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants