-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation, tests and docs of pull request #104 #172
Conversation
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
========================================
+ Coverage 84.3% 85.4% +1.0%
========================================
Files 11 11
Lines 492 494 +2
========================================
+ Hits 415 422 +7
+ Misses 77 72 -5
|
…s (one and two groups)
Thank you!! @sondrelg , any comments?😊 |
@JonasKs ping ? |
I'm sorry, I totally forgot about this. I'll check it out tonight and release before the weekend. |
No worry I also forgot it 😅 |
Looks good to me! 🎉 Could you please bump version like we did here? Otherwise I'll have to wait until Monday to merge and release, but that's okay if you want to wait. 😊 |
No worry for the tag and thanks a lot for the release! :) |
Implementation, tests and docs of pull request snok#104
No description provided.