Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update drf_urls.py #273

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Update drf_urls.py #273

merged 1 commit into from
Mar 30, 2023

Conversation

marshad96
Copy link
Contributor

@marshad96 marshad96 commented Feb 9, 2023

When using with DRF I was getting
django.urls.exceptions.NoReverseMatch: Reverse for 'logout' not found. 'logout' is not a valid view function or pattern name.
to cope that I made a fix.

@tim-schilling
Copy link
Member

This may be unrelated to the PR, but still related to logging out. @JonasKs should the logout view also support post since Django has been moving in that direction? https://docs.djangoproject.com/en/4.1/topics/auth/default/#django.contrib.auth.views.LogoutView

@JonasKs
Copy link
Member

JonasKs commented Feb 9, 2023

This may be unrelated to the PR, but still related to logging out. @JonasKs should the logout view also support post since Django has been moving in that direction? https://docs.djangoproject.com/en/4.1/topics/auth/default/#django.contrib.auth.views.LogoutView

I agree on this! We can deprecate just like Django does, imo.

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #273 (9613730) into master (896d65b) will increase coverage by 0.0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #273   +/-   ##
======================================
  Coverage    86.3%   86.3%           
======================================
  Files           8      11    +3     
  Lines         497     549   +52     
======================================
+ Hits          429     474   +45     
- Misses         68      75    +7     
Impacted Files Coverage Δ
django_auth_adfs/drf_urls.py 100.0% <ø> (ø)
django_auth_adfs/views.py 85.1% <0.0%> (ø)
django_auth_adfs/__init__.py 100.0% <0.0%> (ø)
django_auth_adfs/urls.py 100.0% <0.0%> (ø)

@JonasKs
Copy link
Member

JonasKs commented Mar 30, 2023

Thank you!

@JonasKs JonasKs merged commit 8b7cf83 into snok:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants