Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust logger levels to use info for side-effects #293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adjust logger levels to use info for side-effects #293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions django_auth_adfs/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,17 +147,17 @@ def validate_access_token(self, access_token):
leeway=settings.JWT_LEEWAY
)
except jwt.ExpiredSignatureError as error:
logger.info("Signature has expired: %s", error)
logger.error("Signature has expired: %s", error)
raise PermissionDenied
except jwt.DecodeError as error:
# If it's not the last certificate in the list, skip to the next one
if idx < len(provider_config.signing_keys) - 1:
continue
else:
logger.info('Error decoding signature: %s', error)
logger.error('Error decoding signature: %s', error)
raise PermissionDenied
except jwt.InvalidTokenError as error:
logger.info(str(error))
logger.error(str(error))
raise PermissionDenied

def process_access_token(self, access_token, adfs_response=None):
Expand Down Expand Up @@ -223,7 +223,7 @@ def process_user_groups(self, claims, access_token):
obo_access_token = self.get_obo_access_token(access_token)
groups = self.get_group_memberships_from_ms_graph(obo_access_token)
else:
logger.debug("The configured groups claim %s was not found in the access token",
logger.error("The configured groups claim %s was not found in the access token",
settings.GROUPS_CLAIM)

return groups
Expand Down Expand Up @@ -265,7 +265,7 @@ def create_user(self, claims):
except usermodel.DoesNotExist:
if settings.CREATE_NEW_USERS:
user = usermodel.objects.create(**userdata)
logger.debug("User '%s' has been created.", claims[username_claim])
logger.info("User '%s' has been created.", claims[username_claim])
else:
logger.debug("User '%s' doesn't exist and creating users is disabled.", claims[username_claim])
raise PermissionDenied
Expand Down Expand Up @@ -294,7 +294,7 @@ def update_user_attributes(self, user, claims, claim_mapping=None):
if not isinstance(claim, dict):
if claim in claims:
setattr(user, field, claims[claim])
logger.debug("Attribute '%s' for instance '%s' was set to '%s'.", field, user, claims[claim])
logger.info("Attribute '%s' for instance '%s' was set to '%s'.", field, user, claims[claim])
else:
if field in required_fields:
msg = "Claim not found in access token: '{}'. Check ADFS claims mapping."
Expand Down Expand Up @@ -365,7 +365,7 @@ def update_user_flags(self, user, claims, claim_groups):
else:
value = False
setattr(user, flag, value)
logger.debug("Attribute '%s' for user '%s' was set to '%s'.", flag, user, value)
logger.info("Attribute '%s' for user '%s' was set to '%s'.", flag, user, value)
else:
msg = "User model has no field named '{}'. Check ADFS boolean claims mapping."
raise ImproperlyConfigured(msg.format(flag))
Expand All @@ -376,7 +376,7 @@ def update_user_flags(self, user, claims, claim_groups):
if claim in claims and str(claims[claim]).lower() in ['y', 'yes', 't', 'true', 'on', '1']:
bool_val = True
setattr(user, field, bool_val)
logger.debug("Attribute '%s' for user '%s' was set to '%s'.", field, user, bool_val)
logger.info("Attribute '%s' for user '%s' was set to '%s'.", field, user, bool_val)
else:
msg = "User model has no field named '{}'. Check ADFS boolean claims mapping."
raise ImproperlyConfigured(msg.format(field))
Expand Down
Loading