This repository has been archived by the owner on Nov 19, 2023. It is now read-only.
Trailing slash fix #290
Merged
Trailing slash fix #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current format inlined the first item, then listed the next items using `\n- `. This corrects the behaviour so the first item is also formatted as intended.
It's unclear why this was put in, and it causes problems for users. No significant tests failed in a way that raises any red flags, so this seems like it will be fine to remove.
|
@darduf @radowit would you like to review this? 🙇 |
|
Hi @sondrelg, do you think we could get this fix in a new release soon? |
|
Yes, thanks for pinging me, I've been a little busy the last few days and forget stuff 🙈 I'll release this now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #264
Builds on #288