-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove windows-only logic from the action #95
Conversation
Yeah intending to reproduce, then fix, then merge. Just preemptively set the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.11 is going to be released this month, we should probably test the latest rc2
c4a1b4d
to
d4594c4
Compare
On windows, I thought the path is As this sits, on windows it tries |
1a0e9a3
to
812c0db
Compare
Could we add a temporary |
816b2c3
to
b738097
Compare
Scripts dir is symlinked to bin dir now: This is working now, some of the changes probably can be undone, but we don't need a special path for windows anymore: |
Yep I can do that 👍 |
e83252d
to
aaa1562
Compare
Co-authored-by: miigotu <miigotu@gmail.com>
83e5ad2
to
e647634
Compare
Removes windows-only logic from the action. This seems not to be needed.