Correctly use Systematic Groups in BinnedNLLH::AddPDFs #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 11, 2024
dcookman
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Good spot!
Compiles & passes unit tests (tbf we don't currently have unit tests for this combination of circumstances, so not surprising).
Mercifully this bug will only have impacted those who were trying to use BinnedNLLH by adding multiple PDFs at once, with systematics AND Beeston-Barlow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oof here's a bug and a half. In our BinnedNLLH teststat we have a few overloaded AddPDF and AddPDFs methods. When using AddPDFs, if you pass the systematic groups as an argument, it currently doesn't use the corresponding AddPDF with the syst groups as an argument.
Looks like I introduced it here and it made it through the great merge of 2022!