Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot sort on multiple types in an array #62

Closed
mesqueeb opened this issue Aug 20, 2022 · 2 comments · Fixed by #64
Closed

cannot sort on multiple types in an array #62

mesqueeb opened this issue Aug 20, 2022 · 2 comments · Fixed by #64
Labels
bug

Comments

@mesqueeb
Copy link
Contributor

@snovakovic I noticed that your library fails when an array has multiple types

I'd expect it to first sort all the numbers then all the strings, or the other way around.

image
@mesqueeb mesqueeb mentioned this issue Aug 20, 2022
Closed
mesqueeb added a commit to mesqueeb/fast-sort that referenced this issue Aug 20, 2022
@mesqueeb
fix: snovakovic#62 — can sort on multiple types in an array
6e3fcd5
@mesqueeb
Copy link
Contributor Author

@snovakovic fixed in PR : )

@snovakovic snovakovic mentioned this issue Aug 24, 2022
Merged
@snovakovic snovakovic added the bug label Jan 6, 2023
@snovakovic
Copy link
Owner

@mesqueeb things should work as expected from v3.4.0

TylerJang27 referenced this issue in trunk-io/plugins Apr 19, 2023
@renovate
chore(deps): update all non-major dependencies (#249)
6aa44ec 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence | Type |
Update |
|---|---|---|---|---|---|---|---|
| [@trunkio/launcher](https://trunk.io) | [`1.2.3` ->
`1.2.4`](https://renovatebot.com/diffs/npm/@trunkio%2flauncher/1.2.3/1.2.4)
|
[![age](https://badges.renovateapi.com/packages/npm/@trunkio%2flauncher/1.2.4/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@trunkio%2flauncher/1.2.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@trunkio%2flauncher/1.2.4/compatibility-slim/1.2.3)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@trunkio%2flauncher/1.2.4/confidence-slim/1.2.3)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | patch |
|
[@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/jest)
([source](https://github.com/DefinitelyTyped/DefinitelyTyped)) |
[`29.5.0` ->
`29.5.1`](https://renovatebot.com/diffs/npm/@types%2fjest/29.5.0/29.5.1)
|
[![age](https://badges.renovateapi.com/packages/npm/@types%2fjest/29.5.1/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@types%2fjest/29.5.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@types%2fjest/29.5.1/compatibility-slim/29.5.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@types%2fjest/29.5.1/confidence-slim/29.5.0)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | patch |
|
[@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint)
| [`5.58.0` ->
`5.59.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.58.0/5.59.0)
|
[![age](https://badges.renovateapi.com/packages/npm/@typescript-eslint%2feslint-plugin/5.59.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@typescript-eslint%2feslint-plugin/5.59.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@typescript-eslint%2feslint-plugin/5.59.0/compatibility-slim/5.58.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@typescript-eslint%2feslint-plugin/5.59.0/confidence-slim/5.58.0)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | minor |
|
[@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint)
| [`5.58.0` ->
`5.59.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.58.0/5.59.0)
|
[![age](https://badges.renovateapi.com/packages/npm/@typescript-eslint%2fparser/5.59.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@typescript-eslint%2fparser/5.59.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@typescript-eslint%2fparser/5.59.0/compatibility-slim/5.58.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@typescript-eslint%2fparser/5.59.0/confidence-slim/5.58.0)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | minor |
| [actions/checkout](https://github.com/actions/checkout) | `v3.5.0`
-> `v3.5.2` |
[![age](https://badges.renovateapi.com/packages/github-tags/actions%2fcheckout/v3.5.2/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/github-tags/actions%2fcheckout/v3.5.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/github-tags/actions%2fcheckout/v3.5.2/compatibility-slim/v3.5.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/github-tags/actions%2fcheckout/v3.5.2/confidence-slim/v3.5.0)](https://docs.renovatebot.com/merge-confidence/)
| action | patch |
| [fast-sort](https://github.com/snovakovic/fast-sort) | [`3.2.1` ->
`3.4.0`](https://renovatebot.com/diffs/npm/fast-sort/3.2.1/3.4.0) |
[![age](https://badges.renovateapi.com/packages/npm/fast-sort/3.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/fast-sort/3.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/fast-sort/3.4.0/compatibility-slim/3.2.1)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/fast-sort/3.4.0/confidence-slim/3.2.1)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | minor |
| [github/codeql-action](https://github.com/github/codeql-action) |
`v2.2.11` -> `v2.2.12` |
[![age](https://badges.renovateapi.com/packages/github-tags/github%2fcodeql-action/v2.2.12/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/github-tags/github%2fcodeql-action/v2.2.12/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/github-tags/github%2fcodeql-action/v2.2.12/compatibility-slim/v2.2.11)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/github-tags/github%2fcodeql-action/v2.2.12/confidence-slim/v2.2.11)](https://docs.renovatebot.com/merge-confidence/)
| action | patch |
| [semver](https://github.com/npm/node-semver) | [`7.4.0` ->
`7.5.0`](https://renovatebot.com/diffs/npm/semver/7.4.0/7.5.0) |
[![age](https://badges.renovateapi.com/packages/npm/semver/7.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/semver/7.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/semver/7.5.0/compatibility-slim/7.4.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/semver/7.5.0/confidence-slim/7.4.0)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | minor |

---

### Release Notes

<details>
<summary>typescript-eslint/typescript-eslint
(@&#8203;typescript-eslint/eslint-plugin)</summary>

###
[`v5.59.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5590-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5580v5590-2023-04-17)

[Compare
Source](https://github.com/typescript-eslint/typescript-eslint/compare/v5.58.0...v5.59.0)

##### Bug Fixes

- **eslint-plugin:** \[no-unnecessary-condition] allow nullish
coalescing for naked type parameter
([#&#8203;6910](https://github.com/typescript-eslint/typescript-eslint/issues/6910))
([3e5f858](https://github.com/typescript-eslint/typescript-eslint/commit/3e5f8583f1e4fe045c2fe2143d6f280b7381f96b))

##### Features

- **eslint-plugin:** \[ban-types] add NonNullable suggestion and allow
custom suggestions
([#&#8203;6876](https://github.com/typescript-eslint/typescript-eslint/issues/6876))
([ff65235](https://github.com/typescript-eslint/typescript-eslint/commit/ff65235246bb6214fb64f0e0317373ca99f8bcbe))

</details>

<details>
<summary>typescript-eslint/typescript-eslint
(@&#8203;typescript-eslint/parser)</summary>

###
[`v5.59.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5590-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5580v5590-2023-04-17)

[Compare
Source](https://github.com/typescript-eslint/typescript-eslint/compare/v5.58.0...v5.59.0)

**Note:** Version bump only for package
[@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

</details>

<details>
<summary>actions/checkout</summary>

###
[`v3.5.2`](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v352)

[Compare
Source](https://github.com/actions/checkout/compare/v3.5.1...v3.5.2)

- [Fix api endpoint for
GHES](https://github.com/actions/checkout/pull/1289)

###
[`v3.5.1`](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v351)

[Compare
Source](https://github.com/actions/checkout/compare/v3.5.0...v3.5.1)

- [Fix slow checkout on
Windows](https://github.com/actions/checkout/pull/1246)

</details>

<details>
<summary>snovakovic/fast-sort</summary>

###
[`v3.4.0`](https://github.com/snovakovic/fast-sort/blob/HEAD/CHANGELOG.md#&#8203;340---2023-04-15)

[Compare
Source](https://github.com/snovakovic/fast-sort/compare/v3.3.3...v3.4.0)

##### Fixed

- Issue with sorting multiple types in array
([https://github.com/snovakovic/fast-sort/issues/62](https://github.com/snovakovic/fast-sort/issues/62))

###
[`v3.3.3`](https://github.com/snovakovic/fast-sort/blob/HEAD/CHANGELOG.md#&#8203;333---2023-04-15)

[Compare
Source](https://github.com/snovakovic/fast-sort/compare/ebd4f347e3ad925150107960f1f93537e5b299ef...v3.3.3)

Fix usage in TS environment with `"moduleResolution": "node16"`

###
[`v3.3.2`](https://github.com/snovakovic/fast-sort/compare/ab7e5aa6d691cdd41285622b8cf1111ea7dd300f...ebd4f347e3ad925150107960f1f93537e5b299ef)

[Compare
Source](https://github.com/snovakovic/fast-sort/compare/ab7e5aa6d691cdd41285622b8cf1111ea7dd300f...ebd4f347e3ad925150107960f1f93537e5b299ef)

###
[`v3.3.1`](https://github.com/snovakovic/fast-sort/compare/v3.3.0...ab7e5aa6d691cdd41285622b8cf1111ea7dd300f)

[Compare
Source](https://github.com/snovakovic/fast-sort/compare/v3.3.0...ab7e5aa6d691cdd41285622b8cf1111ea7dd300f)

###
[`v3.3.0`](https://github.com/snovakovic/fast-sort/blob/HEAD/CHANGELOG.md#&#8203;330---2023-04-14)

[Compare
Source](https://github.com/snovakovic/fast-sort/compare/v3.2.1...v3.3.0)

Added proper support for ESM modules

</details>

<details>
<summary>github/codeql-action</summary>

###
[`v2.2.12`](https://github.com/github/codeql-action/compare/v2.2.11...v2.2.12)

[Compare
Source](https://github.com/github/codeql-action/compare/v2.2.11...v2.2.12)

</details>

<details>
<summary>npm/node-semver</summary>

###
[`v7.5.0`](https://github.com/npm/node-semver/blob/HEAD/CHANGELOG.md#&#8203;750-httpsgithubcomnpmnode-semvercomparev740v750-2023-04-17)

[Compare
Source](https://github.com/npm/node-semver/compare/v7.4.0...v7.5.0)

##### Features

-
[`503a4e5`](https://github.com/npm/node-semver/commit/503a4e52fe2b1c6ed1400d33149f7733c8361eed)
[#&#8203;548](https://github.com/npm/node-semver/pull/548) allow
identifierBase to be false
([#&#8203;548](https://github.com/npm/node-semver/issues/548))
([@&#8203;lsvalina](https://github.com/lsvalina))

##### Bug Fixes

-
[`e219bb4`](https://github.com/npm/node-semver/commit/e219bb454036a0c23e34407591f921c8edb688e7)
[#&#8203;552](https://github.com/npm/node-semver/pull/552) throw on
bad version with correct error message
([#&#8203;552](https://github.com/npm/node-semver/issues/552))
([@&#8203;wraithgar](https://github.com/wraithgar))
-
[`fc2f3df`](https://github.com/npm/node-semver/commit/fc2f3df0b5d25253b3580607e111a9a280d888ca)
[#&#8203;546](https://github.com/npm/node-semver/pull/546) incorrect
results from diff sometimes with prerelease versions
([#&#8203;546](https://github.com/npm/node-semver/issues/546))
([@&#8203;tjenkinson](https://github.com/tjenkinson))
-
[`2781767`](https://github.com/npm/node-semver/commit/27817677794f592b592bf6181a80a4824ff762b2)
[#&#8203;547](https://github.com/npm/node-semver/pull/547) avoid
re-instantiating SemVer during diff compare
([#&#8203;547](https://github.com/npm/node-semver/issues/547))
([@&#8203;macno](https://github.com/macno))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/trunk-io/plugins).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40MC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNDkuMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@mesqueeb @snovakovic