Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KNX Multicast without KNXD #152

Merged
merged 3 commits into from
Mar 16, 2020
Merged

Conversation

c-o-m-m-a-n-d-e-r
Copy link
Contributor

Hey,
i think with these changes it will be possible to use a multicast route without KNXD.

Please take a look. Don't sure if i miss something

change KNX Connection to Multicast Routing without KNXD
Indent and Write Callback
fixes config read
@snowdd1
Copy link
Owner

snowdd1 commented Feb 11, 2020

Sorry to be so late, I will try this, and if it works both ways, I will merge it!

@c-o-m-m-a-n-d-e-r
Copy link
Contributor Author

no problem ... i'm not 100% sure but i think there are some bugs i found a little bit later ...
Please check.

<a href="/availservices">list available services</a><br>
<a href="/availcharacteristics">list available characteristics</a>
`);
response.write('<HR><BR>Available pages are <br><a href="/list">list devices</a> and <br><a href="/availservices">list available services</a><br><a href="/availcharacteristics">list available characteristics</a>');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you convert all multi-line strings to single line strings? Some issue with your IDE?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops, i think there was a plugin in my IDE over motivated ...

snowdd1 added a commit that referenced this pull request Mar 16, 2020
Fix GarageDoorOpenerAdvanced & Includes #152 implicitly.
@snowdd1 snowdd1 merged commit 3708125 into snowdd1:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants